Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29402586: Issue 5086 - Add webrtc connection type (Closed)

Created:
April 4, 2017, 1:26 p.m. by Wladimir Palant
Modified:
April 5, 2017, 12:21 p.m.
Reviewers:
sergei, kzar
CC:
Felix Dahlke, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5086 - Add webrtc connection type

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M compiled/filter/RegExpFilter.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M test/regexpFilters_matching.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
April 4, 2017, 1:26 p.m. (2017-04-04 13:26:06 UTC) #1
sergei
https://codereview.adblockplus.org/29402586/diff/29402587/test/regexpFilters_matching.js File test/regexpFilters_matching.js (right): https://codereview.adblockplus.org/29402586/diff/29402587/test/regexpFilters_matching.js#newcode133 test/regexpFilters_matching.js:133: testMatch(test, "abc$~websocket", "http://abc/adf", "WEBSOCKT", null, false, null, false); typo: ...
April 4, 2017, 1:32 p.m. (2017-04-04 13:32:13 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29402586/diff/29402587/test/regexpFilters_matching.js File test/regexpFilters_matching.js (right): https://codereview.adblockplus.org/29402586/diff/29402587/test/regexpFilters_matching.js#newcode133 test/regexpFilters_matching.js:133: testMatch(test, "abc$~websocket", "http://abc/adf", "WEBSOCKT", null, false, null, false); On ...
April 4, 2017, 1:37 p.m. (2017-04-04 13:37:18 UTC) #3
kzar
Perhaps Segei should be the reviewer for this one? I don't know much C++ yet.
April 5, 2017, 10:12 a.m. (2017-04-05 10:12:14 UTC) #4
sergei
April 5, 2017, 11:30 a.m. (2017-04-05 11:30:05 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld