Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 
 import org.adblockplus.libadblockplus.IsAllowedConnectionCallback;
 import org.adblockplus.libadblockplus.android.Utils;
 
 public class IsAllowedConnectionCallbackImpl extends IsAllowedConnectionCallback
 {
   private static final String TAG = Utils.getTag(IsAllowedConnectionCallbackImpl.class);
 
   private ConnectivityManager manager;
 
-  public IsAllowedConnectionCallbackImpl(Context context)

[anton, 2017/04/15 13:58:03]

minor change (taking into account law of demeter).
now it's easier to mock.

+  public IsAllowedConnectionCallbackImpl(ConnectivityManager manager)
   {
     super();
-    this.manager = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
+    this.manager = manager;
   }
 
   @Override
   public boolean isConnectionAllowed(String connection)
   {
     Log.d(TAG, "Checking connection: " + connection);
 
     if (connection == null)
     {
       // required connection type is not specified - any works
@@ skipping 16 matching lines @@
 
     if (!connectionType.isRequiredConnection(manager))
     {
       Log.w(TAG, "Current connection type is not allowed for web requests");
       return false;
     }
 
     return true;
   }
 }