Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29413555: Issue 5145 - Add test for IsAllowedConnectionCallbackImpl (Closed)

Created:
April 15, 2017, 1:55 p.m. by anton
Modified:
May 10, 2017, 7:21 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

Patch Set 1 #

Total comments: 6

Patch Set 2 : added "static final" #

Messages

Total messages: 5
anton
https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java (left): https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java#oldcode34 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java:34: public IsAllowedConnectionCallbackImpl(Context context) minor change (taking into account law ...
April 15, 2017, 1:58 p.m. (2017-04-15 13:58:03 UTC) #1
diegocarloslima
Looks good, but I think is a good practice to declare inner classes as static ...
April 27, 2017, 7:04 p.m. (2017-04-27 19:04:59 UTC) #2
anton
see new patch set https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java (right): https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java#newcode37 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java:37: private class TestRequest extends AndroidWebRequest ...
April 28, 2017, 6:16 a.m. (2017-04-28 06:16:23 UTC) #3
diegocarloslima
On 2017/04/28 06:16:23, anton wrote: > see new patch set > > https://codereview.adblockplus.org/29413555/diff/29413556/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java > File ...
April 28, 2017, 11:30 a.m. (2017-04-28 11:30:51 UTC) #4
Felix Dahlke
May 9, 2017, 8:08 a.m. (2017-05-09 08:08:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld