libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java - Issue 29413555: Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Issue 29413555: Issue 5145 - Add test for IsAllowedConnectionCallbackImpl (Closed)

Patch Set: added "static final" Created April 28, 2017, 6:15 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/IsAllowedConnectionCallbackImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

index 660346e5ef0032575b6892ec39c6f76871be9dc7..2358295665018e23066267f9cf4df844b9fa54be 100644

--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

@@ -19,6 +19,7 @@ package org.adblockplus.libadblockplus.android.settings;

import android.content.Context;

import android.content.SharedPreferences;

+import android.net.ConnectivityManager;

import android.util.Log;

import org.adblockplus.libadblockplus.IsAllowedConnectionCallback;

@@ -141,7 +142,9 @@ public class AdblockHelper

private void createAdblock()

{

- this.isAllowedConnectionCallback = new IsAllowedConnectionCallbackImpl(context);

+ ConnectivityManager connectivityManager =

+ (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);

+ this.isAllowedConnectionCallback = new IsAllowedConnectionCallbackImpl(connectivityManager);

Log.d(TAG, "Creating adblock engine ...");