Issue 29419604: Noissue - Do not redirect modern ABB versions to noelemhide filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29419604: Noissue - Do not redirect modern ABB versions to noelemhide filters (Closed)

Created:
April 21, 2017, 11:44 a.m. by f.nicolaisen

Modified:
April 24, 2017, 7:25 a.m.

Reviewers:
mathias, Fred

CC:
Felix Dahlke, sporz

Base URL:
https://hg1/infrastructure

Visibility:
Public.

Description

Noissue - Do not redirect modern ABB versions to noelemhide filters See http://hub.eyeo.com/issues/735

Patch Set 2 : improve regexp with escaped dot #

Patch Set 3 : move check down to where it makes sense #

Total comments: 1

Patch Set 4 : improve regexp #

Created: April 21, 2017, 3:14 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	modules/filterserver/files/site.conf	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

f.nicolaisen

New version uploaded that actually works in PS3 :)

April 21, 2017, 1:45 p.m. (2017-04-21 13:45:39 UTC) #4

mathias

https://codereview.adblockplus.org/29419604/diff/29419621/modules/filterserver/files/site.conf File modules/filterserver/files/site.conf (right): https://codereview.adblockplus.org/29419604/diff/29419621/modules/filterserver/files/site.conf#newcode40 modules/filterserver/files/site.conf:40: if ($arg_addonVersion ~ ^(2\.)(7|8|9)($|\.).*$) Why is the major version ...

April 21, 2017, 2:54 p.m. (2017-04-21 14:54:26 UTC) #5

f.nicolaisen

Matze's comments have been addressed in PS4. That is also now live on filter12: curl ...

April 21, 2017, 3:15 p.m. (2017-04-21 15:15:14 UTC) #6

LGTM.

Expand All Messages | Collapse All Messages