Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29420561: Noissue - don't inherit JsValue derived from std::enable_shared_from_this (Closed)

Created:
April 24, 2017, 8:26 a.m. by sergei
Modified:
April 25, 2017, 8:18 a.m.
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

Since #5034 is finished that inheritance is no longer needed. Review: https://codereview.adblockplus.org/29420561/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M include/AdblockPlus/FilterEngine.h View 2 chunks +2 lines, -4 lines 0 comments Download
M include/AdblockPlus/Notification.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
April 24, 2017, 8:28 a.m. (2017-04-24 08:28:59 UTC) #1
hub
April 24, 2017, 1:56 p.m. (2017-04-24 13:56:12 UTC) #2
On 2017/04/24 08:28:59, sergei wrote:

LGTM

Powered by Google App Engine
This is Rietveld