Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29435584: Issue 4181 - Fix FilterEngineTest tests (Closed)

Created:
May 10, 2017, 10:56 a.m. by anton
Modified:
Oct. 29, 2018, 5:38 p.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4181 - Fix FilterEngineTest tests Old version of patch set https://codereview.adblockplus.org/29347192/

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -3 lines) Patch
A libadblockplus-android-tests/src/org/adblockplus/libadblockplus/FileSystemUtils.java View 1 chunk +87 lines, -0 lines 1 comment Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java View 2 chunks +32 lines, -2 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
anton
a new version of code review instead of old one https://codereview.adblockplus.org/29347192/
May 10, 2017, 10:58 a.m. (2017-05-10 10:58:00 UTC) #1
anton
May 10, 2017, 11:02 a.m. (2017-05-10 11:02:33 UTC) #2
https://codereview.adblockplus.org/29435584/diff/29435585/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/FileSystemUtils.java
(right):

https://codereview.adblockplus.org/29435584/diff/29435585/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/FileSystemUtils.java:27:
public class FileSystemUtils
BTW we could use Apache file utils in the tests at least.
But the class was already written then, so just using it.

Powered by Google App Engine
This is Rietveld