Issue 5231 - Use Java 7 features

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/DefaultSubscriptions.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
 import javax.xml.parsers.ParserConfigurationException;
 import javax.xml.parsers.SAXParser;
 import javax.xml.parsers.SAXParserFactory;
 
 import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 import org.xml.sax.helpers.DefaultHandler;
 
 final class DefaultSubscriptions
 {
-  private final List<DefaultSubscriptionInfo> subscriptions = new ArrayList<DefaultSubscriptionInfo>();
-  private final List<DefaultSubscriptionInfo> linearSubscriptions = new ArrayList<DefaultSubscriptionInfo>();
-  private final HashMap<String, DefaultSubscriptionInfo> urlMap = new HashMap<String, DefaultSubscriptionInfo>();
-  private final List<DefaultSubscriptionInfo> adsSubscriptions = new ArrayList<DefaultSubscriptionInfo>();
-  private final List<DefaultSubscriptionInfo> otherSubscriptions = new ArrayList<DefaultSubscriptionInfo>();
+  private final List<DefaultSubscriptionInfo> subscriptions = new ArrayList<>();
+  private final List<DefaultSubscriptionInfo> linearSubscriptions = new ArrayList<>();
+  private final HashMap<String, DefaultSubscriptionInfo> urlMap = new HashMap<>();
+  private final List<DefaultSubscriptionInfo> adsSubscriptions = new ArrayList<>();
+  private final List<DefaultSubscriptionInfo> otherSubscriptions = new ArrayList<>();
 
   private DefaultSubscriptions initialize()
   {
     this.listSubscriptions(this.linearSubscriptions);
 
     for (final DefaultSubscriptionInfo s : this.linearSubscriptions)
     {
       final String url = s.getUrl();
       final String type = s.getType();
 
@@ skipping 10 matching lines @@
       {
         this.otherSubscriptions.add(s);
       }
     }
 
     return this;
   }
 
   public List<Subscription> createSubscriptions() throws IOException
   {
-    final ArrayList<Subscription> subs = new ArrayList<Subscription>();
+    final ArrayList<Subscription> subs = new ArrayList<>();
     for (DefaultSubscriptionInfo info : this.linearSubscriptions)
     {
       if (!info.getUrl().isEmpty())
       {
         final Subscription sub = Subscription.create(info.getUrl());
         sub.putMeta(Subscription.KEY_TITLE, info.getTitle());
         subs.add(sub);
       }
     }
     return subs;
@@ skipping 35 matching lines @@
   {
     try
     {
       final SAXParserFactory factory = SAXParserFactory.newInstance();
       factory.setValidating(false);
       final SAXParser parser = factory.newSAXParser();
       final SubscriptionParser handler = new SubscriptionParser();
       parser.parse(in, handler);
       return handler.subscriptions.initialize();
     }
-    catch (final ParserConfigurationException e)
+    catch (final ParserConfigurationException | SAXException e)
     {
-      throw new IOException("ParserConfigurationException: " + e.getMessage());
-    }
-    catch (final SAXException e)
-    {
-      e.printStackTrace();
-      throw new IOException("SAXException: " + e.getMessage());
+      throw new IOException(e.getClass().getSimpleName() + ": " + e.getMessage());
     }
   }
 
   private static class SubscriptionParser extends DefaultHandler
   {
     private boolean inSubscriptions = false;
     private boolean inVariants = false;
 
     private final static String KEY_SUPPLEMENTS = "supplements";
     private final static String KEY_SUBSCRIPTIONS = "subscriptions";
     private final static String KEY_SUBSCRIPTION = "subscription";
     private final static String KEY_VARIANTS = "variants";
     private final static String KEY_VARIANT = "variant";
 
     private final DefaultSubscriptions subscriptions = new DefaultSubscriptions();
-    private final LinkedList<DefaultSubscriptionInfo> subscriptionStack = new LinkedList<DefaultSubscriptionInfo>();
+    private final LinkedList<DefaultSubscriptionInfo> subscriptionStack = new LinkedList<>();
     private DefaultSubscriptionInfo subscription = null;
     private DefaultSubscriptionInfo variant = null;
 
     @Override
     public void startElement(final String uri, final String localName, final String qName,
         final Attributes attributes) throws SAXException
     {
       super.startElement(uri, localName, qName, attributes);
 
       if (KEY_SUBSCRIPTIONS.equals(qName))
@@ skipping 121 matching lines @@
       }
     }
   }
 
   @Override
   public String toString()
   {
     return this.linearSubscriptions.toString();
   }
 }