Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29436555: Issue 5231 - Use Java 7 features (Closed)

Created:
May 11, 2017, 6:30 p.m. by diegocarloslima
Modified:
May 26, 2017, 8:09 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke, jens
Visibility:
Public.

Description

Issue 5231 - Use Java 7 features

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -162 lines) Patch
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/ListedSubscriptionsPreferenceCategory.java View 2 chunks +2 lines, -2 lines 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/MoreBlockingPreferenceCategory.java View 1 chunk +1 line, -1 line 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java View 1 chunk +1 line, -1 line 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/DefaultSubscriptionInfo.java View 1 chunk +3 lines, -3 lines 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/DefaultSubscriptions.java View 3 chunks +9 lines, -14 lines 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java View 5 chunks +8 lines, -12 lines 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 11 chunks +34 lines, -58 lines 2 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java View 1 chunk +1 line, -1 line 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java View 5 chunks +17 lines, -60 lines 0 comments Download
M adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java View 5 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4
diegocarloslima
May 11, 2017, 6:33 p.m. (2017-05-11 18:33:44 UTC) #1
anton
On 2017/05/11 18:33:44, diegocarloslima wrote: LGTM if you check the notes above don't hurt.
May 12, 2017, 5:49 a.m. (2017-05-12 05:49:22 UTC) #2
anton
https://codereview.adblockplus.org/29436555/diff/29436556/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java File adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java (right): https://codereview.adblockplus.org/29436555/diff/29436556/adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java#newcode430 adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java:430: try (final BufferedReader r = new BufferedReader(new InputStreamReader( Now ...
May 12, 2017, 5:49 a.m. (2017-05-12 05:49:28 UTC) #3
Felix Dahlke
May 15, 2017, 3:31 p.m. (2017-05-15 15:31:47 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld