Issue 5231 - Use Java 7 features

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.sbrowser.contentblocker.engine;
 
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.locks.ReentrantLock;
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.util.Log;
 
 @SuppressLint("DefaultLocale")
 final class Downloader
 {
   private static final int MAX_RETRIES = 5;
 
   private static final String TAG = Downloader.class.getSimpleName();
   private final Engine engine;
   private final ReentrantLock accessLock = new ReentrantLock();
   private Thread downloaderThread;
-  private LinkedBlockingQueue<DownloadJob> downloadJobs = new LinkedBlockingQueue<DownloadJob>();
-  private HashSet<String> enqueuedIds = new HashSet<String>();
+  private LinkedBlockingQueue<DownloadJob> downloadJobs = new LinkedBlockingQueue<>();
+  private HashSet<String> enqueuedIds = new HashSet<>();
   private boolean downloaderEnabled = true;
 
   private Downloader(final Engine engine)
   {
     this.engine = engine;
   }
 
   void lock()
   {
     this.accessLock.lock();
@@ skipping 37 matching lines @@
       final String key = connection.getHeaderFieldKey(i);
       if (key == null)
       {
         break;
       }
       final String value = connection.getHeaderField(i);
       job.responseHeaders.put(key.toLowerCase(), value);
     }
 
     final StringBuilder sb = new StringBuilder();
-    final BufferedReader r = new BufferedReader(new InputStreamReader(connection.getInputStream(),
-        Engine.CHARSET_UTF_8));
-    try
+    try (final BufferedReader r = new BufferedReader(new InputStreamReader(
+        connection.getInputStream(), StandardCharsets.UTF_8)))
     {
       for (int ch = r.read(); ch != -1; ch = r.read())
       {
         sb.append((char) ch);
       }
       job.responseText = sb.toString();
     }
-    finally
-    {
-      r.close();
-    }
   }
 
   public void enqueueDownload(final URL url, final String id, final Map<String, String> headers)
   {
     this.lock();
     try
     {
       if (!this.enqueuedIds.contains(id))
       {
         this.enqueuedIds.add(id);
@@ skipping 25 matching lines @@
 
     public DownloaderHandler(final Downloader downloader)
     {
       this.downloader = downloader;
     }
 
     @Override
     public void run()
     {
       Log.d(TAG, "Handler thread started");
-      final LinkedBlockingQueue<DownloadJob> reQueue = new LinkedBlockingQueue<DownloadJob>();
+      final LinkedBlockingQueue<DownloadJob> reQueue = new LinkedBlockingQueue<>();
       boolean interrupted = false;
       while (!interrupted)
       {
         DownloadJob job = null;
         try
         {
           if (!this.downloader.downloaderEnabled)
           {
             Thread.sleep(30000);
             continue;
@@ skipping 68 matching lines @@
         }
       }
       Log.d(TAG, "Handler thread finished");
     }
   }
 
   private static class DownloadJob
   {
     private final URL url;
     private final String id;
-    private final HashMap<String, String> headers = new HashMap<String, String>();
+    private final HashMap<String, String> headers = new HashMap<>();
     private int retryCount = 0;
 
     private int responseCode = 0;
-    private HashMap<String, String> responseHeaders = new HashMap<String, String>();
+    private HashMap<String, String> responseHeaders = new HashMap<>();
     private String responseText = null;
 
     public DownloadJob(final URL url, final String id, final Map<String, String> headers)
     {
       this.url = url;
       this.id = id;
       if (headers != null)
       {
         this.headers.putAll(headers);
       }
     }
   }
 }