Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29438568: Noissue - Improve CMS repository pull command (Closed)

Created:
May 16, 2017, 12:58 a.m. by f.lopez
Modified:
May 16, 2017, 9:37 p.m.
Reviewers:
mathias, f.nicolaisen
CC:
Fred
Visibility:
Public.

Description

With style standards and quote functions

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 3 #

Patch Set 3 : For comment 3 as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M modules/web/manifests/server.pp View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7
f.lopez
May 16, 2017, 12:58 a.m. (2017-05-16 00:58:44 UTC) #1
f.nicolaisen
Commit message nitpick: Improve how? It seems more intuitive to me that this patch improve ...
May 16, 2017, 8:48 a.m. (2017-05-16 08:48:27 UTC) #2
mathias
Am I overseeing something or does this patch just change how the command is assembled, ...
May 16, 2017, 9 a.m. (2017-05-16 09:00:07 UTC) #3
f.lopez
May 16, 2017, 7:09 p.m. (2017-05-16 19:09:15 UTC) #4
f.lopez
May 16, 2017, 7:11 p.m. (2017-05-16 19:11:48 UTC) #5
f.lopez
On 2017/05/16 08:48:27, f.nicolaisen wrote: > Commit message nitpick: Improve how? Like that?? > It ...
May 16, 2017, 7:15 p.m. (2017-05-16 19:15:39 UTC) #6
mathias
May 16, 2017, 8:48 p.m. (2017-05-16 20:48:27 UTC) #7
LGTM. Note that I've modified the title / commit-message slightly.

Powered by Google App Engine
This is Rietveld