Noissue - Improve web repository clone command

modules/web/manifests/server.pp

 class web::server(
     $vhost,
     $repository,
     $certificate = hiera('web::server::certificate', 'undef'),
     $private_key = hiera('web::server::private_key', 'undef'),
     $is_default = false,
     $aliases = undef,
     $custom_config = undef,
     $multiplexer_locations = undef,
     $geoip = false,
@@ skipping 89 matching lines @@
   }
 
   exec {"fetch_cms":
     command => "hg clone https://hg.adblockplus.org/cms/ /opt/cms",
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     timeout => 0,
     creates => "/opt/cms/.hg/hgrc",
   }
 
+  $fetch_repo_cmd = [
+    "hg", "clone", "-U", "https://hg.adblockplus.org/${repository}",

[mathias, 2017/05/16 09:02:07]

Please use single quotes.

+    "/home/www/${repository}",
+  ]
+
   exec {"fetch_repo":
-    command => "hg clone -U https://hg.adblockplus.org/${repository} /home/www/${repository}",
+    command => shellquote($fetch_repo_cmd),
     path => ["/usr/bin/", "/bin/"],
     require => Package['mercurial'],
     user => www,
     timeout => 0,
     creates => "/home/www/${repository}/.hg/hgrc",
   }
 
   $initialize_content_exec = [
     'python', '-m', 'cms.bin.generate_static_pages',
     "/home/www/${repository}", "/var/www/${vhost}",
@@ skipping 42 matching lines @@
   )
 
   cron {'update_repo':
     ensure => present,
     command => $update_webpage_cmd,
     user => www,
     minute  => '5-59/20',
   }
 
 }