Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29438571: Noissue - Improve web repository clone command (Closed)

Created:
May 16, 2017, 1:01 a.m. by f.lopez
Modified:
May 16, 2017, 8:45 p.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

style and format? For puppet and eyeo standards

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M modules/web/manifests/server.pp View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4
f.lopez
May 16, 2017, 1:01 a.m. (2017-05-16 01:01:13 UTC) #1
mathias
https://codereview.adblockplus.org/29438571/diff/29438572/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29438571/diff/29438572/modules/web/manifests/server.pp#newcode111 modules/web/manifests/server.pp:111: "hg", "clone", "-U", "https://hg.adblockplus.org/${repository}", Please use single quotes.
May 16, 2017, 9:02 a.m. (2017-05-16 09:02:07 UTC) #2
f.lopez
May 16, 2017, 7:26 p.m. (2017-05-16 19:26:27 UTC) #3
mathias
May 16, 2017, 8:44 p.m. (2017-05-16 20:44:58 UTC) #4
LGTM. Note that I've modified the title / commit-message slightly.

Powered by Google App Engine
This is Rietveld