Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29438574: Noissue - Improve CMS repository clone command (Closed)

Created:
May 16, 2017, 1:04 a.m. by f.lopez
Modified:
May 16, 2017, 8:48 p.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

Format and style? according to puppet standard

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M modules/web/manifests/server.pp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4
f.lopez
May 16, 2017, 1:04 a.m. (2017-05-16 01:04:36 UTC) #1
mathias
https://codereview.adblockplus.org/29438574/diff/29438575/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29438574/diff/29438575/modules/web/manifests/server.pp#newcode103 modules/web/manifests/server.pp:103: "hg", "clone", "https://hg.adblockplus.org/cms/", "/opt/cms", Please use single quotes.
May 16, 2017, 9:01 a.m. (2017-05-16 09:01:33 UTC) #2
f.lopez
May 16, 2017, 7:18 p.m. (2017-05-16 19:18:28 UTC) #3
mathias
May 16, 2017, 8:46 p.m. (2017-05-16 20:46:53 UTC) #4
LGTM. Note that I've modified the title / commit-message slightly.

Powered by Google App Engine
This is Rietveld