Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29447560: Noissue - Update preferences page for Adblock Plus 2.9 release (Closed)

Created:
May 24, 2017, 12:51 p.m. by Wladimir Palant
Modified:
May 30, 2017, 12:17 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Noissue - Update preferences page for Adblock Plus 2.9 release

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M pages/preferences.tmpl View 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
May 24, 2017, 12:51 p.m. (2017-05-24 12:51:35 UTC) #1
saroyanm
LGTM Maybe we can add link to the notes in the review description: https://adblockplus.org/releases/adblock-plus-29-for-firefox-released
May 30, 2017, 11:30 a.m. (2017-05-30 11:30:35 UTC) #2
Wladimir Palant
On 2017/05/30 11:30:35, saroyanm wrote: > Maybe we can add link to the notes in ...
May 30, 2017, 11:58 a.m. (2017-05-30 11:58:28 UTC) #3
saroyanm
May 30, 2017, 12:17 p.m. (2017-05-30 12:17:05 UTC) #4
Message was sent while issue was closed.
On 2017/05/30 11:58:28, Wladimir Palant wrote:
> On 2017/05/30 11:30:35, saroyanm wrote:
> > Maybe we can add link to the notes in the review description:
> > https://adblockplus.org/releases/adblock-plus-29-for-firefox-released
> 
> No, it's already questionable that we are linking to the issue tracker in
> release announcements - linking to code reviews would definitely go too far,
it
> is very much an internal tool.

I meant to suggest linking from the current Codereview to the release notes
while there is no issue number.

Powered by Google App Engine
This is Rietveld