Noissue - Replace hypens with underscore due compatibility with parser future

Noissue - Replace hypens with underscore due compatibility with parser future

See http://hub.eyeo.com/issues/1254

[mathias, 2017-05-24 17:51:27]

Regarding the commit-message: I have not the slightest clue what it's trying to
say. I guess you something like "replace minus with underscore in type names".
But is there more to it? If so, please explain to me what exactly constitutes an
"illegal fully qualified name". If not, there should be no need to encrypt the
commit message that way. Oh, and I doubt that "deprecation puppet version" is a
thing.

Regarding the patch: Shouldn't we change both the php-pool.pp and README.md bits
accordingly in the same commit?

[f.lopez, 2017-05-24 18:00:14]

On 2017/05/24 17:51:27, mathias wrote:
> Regarding the commit-message: I have not the slightest clue what it's trying
to
> say. I guess you something like "replace minus with underscore in type names".
> But is there more to it? If so, please explain to me what exactly constitutes
an
> "illegal fully qualified name". If not, there should be no need to encrypt the
> commit message that way. Oh, and I doubt that "deprecation puppet version" is
a
> thing.
> 
> Regarding the patch: Shouldn't we change both the php-pool.pp and README.md
bits
> accordingly in the same commit?

IS that commit message better? 

I changed the php_pool and the README (although I don't know why it wasn't
pushed, gonna send another review)

[mathias, 2017-05-24 19:17:56]

On 2017/05/24 18:00:14, f.lopez wrote:
> IS that commit message better? 

Yes, though the grammar could still be improved.

[mathias, 2017-05-25 15:23:40]

LGTM for commit as new in-module/spawn_fcgi directly within the infrastructure
repository. Don't migrate the code using this module yet, that should be
separate commits, followed by removing the sub-module in a last one. Suggested
commit message: "Noissue - Introduce module spawn_fcgi as export of submodule
spawn-fcgi", plus linking the ticket below.