Issue 4327 - Do not apply $subdocument filters to top-level documents

Issue 4327 - Do not apply $subdocument filters to top-level documents

[Manish Jethani, 2017-06-06 12:54:19]

Patch Set 1

Exclude top-level documents by specifying the new unless-top-url property. This
change is backwards compatible, since older versions of Safari will ignore the
property.

Also note that we could simply merge unless-domain and unless-top-url instead of
making them exclusive, but then we'd be dropping support for older versions of
Safari.

[Sebastian Noack, 2017-06-06 13:50:00]

LGTM from my side. Please wait for kzar to review it as well.

[kzar, 2017-06-08 11:52:28]

How do older versions of Safari handle these new options. Are they simply
ignored, or are the rules using them ignored, or does the whole list fail to
load?

I wonder if we should have an option for minimum Safari supported, so we can
still generate rule lists for older versions? Then we could have two versions
hosted online and the mobile app would download the correct one depending on the
Safari version. That way we could make use of the newer features, whilst still
having a fall back that doesn't have too many false positives.

[Sebastian Noack, 2017-06-08 12:10:08]

On 2017/06/08 11:52:28, kzar wrote:
> How do older versions of Safari handle these new options. Are they simply
> ignored, or are the rules using them ignored, or does the whole list fail to
> load?
> 
> I wonder if we should have an option for minimum Safari supported, so we can
> still generate rule lists for older versions? Then we could have two versions
> hosted online and the mobile app would download the correct one depending on
the
> Safari version. That way we could make use of the newer features, whilst still
> having a fall back that doesn't have too many false positives.

As per Manish's comment above, older versions of Safari will just ignore the
"unless-top-url" property added here, and therefore behave the same as they did
before this change.

[kzar, 2017-06-08 12:20:51]

On 2017/06/08 12:10:08, Sebastian Noack wrote:
> On 2017/06/08 11:52:28, kzar wrote:
> > How do older versions of Safari handle these new options. Are they simply
> > ignored, or are the rules using them ignored, or does the whole list fail to
> > load?
> As per Manish's comment above, older versions of Safari will just ignore the
> "unless-top-url" property added here, and therefore behave the same as they
did
> before this change.

Whoops sorry, missed that. LGTM.