Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29458555: Issue 4967 - Job ads on eyeo.com should use headings for headings (Closed)

Created:
June 7, 2017, 9:37 a.m. by ire
Modified:
June 8, 2017, 1:30 p.m.
Reviewers:
juliandoucette
CC:
Lisa
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue 4967 - Job ads on eyeo.com should use headings for headings

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M includes/jobs/benefits.md View 1 chunk +1 line, -1 line 2 comments Download
M includes/jobs/why.md View 1 chunk +3 lines, -3 lines 0 comments Download
M pages/jobs/filter-list-supporter.md View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/jobs/frontend-developer.md View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/jobs/mobile-product-manager.md View 1 chunk +4 lines, -4 lines 0 comments Download
M pages/jobs/speculative-application.md View 1 chunk +5 lines, -3 lines 0 comments Download
M pages/jobs/technical-support-specialist.md View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/jobs/whitelist-maintainer.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ire
June 7, 2017, 9:37 a.m. (2017-06-07 09:37:28 UTC) #1
ire
https://codereview.adblockplus.org/29458555/diff/29458556/includes/jobs/benefits.md File includes/jobs/benefits.md (right): https://codereview.adblockplus.org/29458555/diff/29458556/includes/jobs/benefits.md#newcode1 includes/jobs/benefits.md:1: ### What we offer... I think this should have ...
June 7, 2017, 9:38 a.m. (2017-06-07 09:38:57 UTC) #2
juliandoucette
CCing Lisa. https://codereview.adblockplus.org/29458555/diff/29458556/includes/jobs/benefits.md File includes/jobs/benefits.md (right): https://codereview.adblockplus.org/29458555/diff/29458556/includes/jobs/benefits.md#newcode1 includes/jobs/benefits.md:1: ### What we offer... On 2017/06/07 09:38:57, ...
June 7, 2017, 5:49 p.m. (2017-06-07 17:49:48 UTC) #3
juliandoucette
Note: This patch no longer applies. Please rebase.
June 7, 2017, 5:56 p.m. (2017-06-07 17:56:15 UTC) #4
juliandoucette
June 7, 2017, 6:01 p.m. (2017-06-07 18:01:21 UTC) #5
On 2017/06/07 17:56:15, juliandoucette wrote:
> Note: This patch no longer applies. Please rebase.

Beyond that, LGTM.

Powered by Google App Engine
This is Rietveld