Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29458590: Noissue - Use parameter for network interface in the check_bandwidth nagios plugin (Closed)

Created:
June 7, 2017, 12:38 p.m. by f.lopez
Modified:
June 8, 2017, 2:58 p.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

Noissue - Use parameter for network interface in the check_bandwidth nagios plugin See http://hub.eyeo.com/issues/1441

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M modules/nagios/files/check_bandwidth View 1 1 chunk +5 lines, -4 lines 0 comments Download
M modules/nagios/templates/nrpe.cfg.erb View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
f.lopez
June 7, 2017, 12:38 p.m. (2017-06-07 12:38:51 UTC) #1
mathias
https://codereview.adblockplus.org/29458590/diff/29458591/modules/nagios/files/check_bandwidth File modules/nagios/files/check_bandwidth (right): https://codereview.adblockplus.org/29458590/diff/29458591/modules/nagios/files/check_bandwidth#newcode21 modules/nagios/files/check_bandwidth:21: NIC = str(sys.argv[3]) This shouldn't be an upper-case name ...
June 7, 2017, 3:27 p.m. (2017-06-07 15:27:23 UTC) #2
f.lopez
June 8, 2017, 1:13 p.m. (2017-06-08 13:13:20 UTC) #3
mathias
June 8, 2017, 1:34 p.m. (2017-06-08 13:34:56 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld