Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29463591: Noissue - Remove faulty postconf custom configuration (Closed)

Created:
June 12, 2017, 8:33 p.m. by f.nicolaisen
Modified:
June 12, 2017, 9:35 p.m.
Reviewers:
mathias
CC:
rick_adblockplus.org
Base URL:
https://hg1/infrastructure
Visibility:
Public.

Description

Noissue - Remove faulty postconf custom configuration Due to us configuring the mydestination field, postfix was unable to recognize mails coming from local accounts, resulting in it trying to send replies (for example for bounced emails) to the external IP of the account. Consider the old configuration (before this commit): root@acceptableads-com-1 ~ # postconf | grep 'mydestination =' mydestination = localhost.localdomain, localhost In the above configuration, we are missing the domain "acceptableads-com-1.adblockplus.org", because emails from nginx will be sent from nginx@acceptableads-com-1.adblockplus.org. The default configuration (which we override) includes the domain: root@acceptableads-com-1 ~ # postconf -d | grep 'mydestination =' mydestination = $myhostname, localhost.$mydomain, localhost root@acceptableads-com-1 ~ # postconf -d | grep 'myhostname =' myhostname = acceptableads-com-1.adblockplus.org By removing the configuration line, we ensure that postfix recognizes emails like the one from nginx above as being from local accounts. See http://hub.eyeo.com/issues/1487#note-2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M modules/postfix/files/main.cf View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
f.nicolaisen
June 12, 2017, 8:33 p.m. (2017-06-12 20:33:33 UTC) #1
mathias
June 12, 2017, 9:21 p.m. (2017-06-12 21:21:03 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld