Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29464623: #1374 - Redirect ZTE users to minimized filter-lists (Closed)

Created:
June 13, 2017, 1:41 p.m. by mathias
Modified:
June 13, 2017, 2:30 p.m.
Reviewers:
f.lopez, f.nicolaisen
CC:
Fred
Visibility:
Public.

Description

#1374 - Redirect ZTE users to minimized filter-lists

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M modules/filterserver/files/site.conf View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
June 13, 2017, 1:41 p.m. (2017-06-13 13:41:11 UTC) #1
f.lopez
On 2017/06/13 13:41:11, mathias wrote: LGTM
June 13, 2017, 1:50 p.m. (2017-06-13 13:50:17 UTC) #2
f.nicolaisen
The commit message looks like it's for trac, not a hub ticket.
June 13, 2017, 2:21 p.m. (2017-06-13 14:21:34 UTC) #3
mathias
On 2017/06/13 14:21:34, f.nicolaisen wrote: > The commit message looks like it's for trac, not ...
June 13, 2017, 2:24 p.m. (2017-06-13 14:24:48 UTC) #4
f.nicolaisen
June 13, 2017, 2:30 p.m. (2017-06-13 14:30:52 UTC) #5
Message was sent while issue was closed.
On 2017/06/13 14:24:48, mathias wrote:
> On 2017/06/13 14:21:34, f.nicolaisen wrote:
> > The commit message looks like it's for trac, not a hub ticket.
> 
> How come?

OK, reading your instructions again, I misunderstood it as such: that hub ticket
references should be at the end of the message as URLs, like "See http://hub..."

Powered by Google App Engine
This is Rietveld