Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469584: #1634 - Update file resource syntax in module adblockplus (Closed)

Created:
June 20, 2017, 4:42 p.m. by f.lopez
Modified:
June 22, 2017, 9:45 a.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1634 - Update file resource syntax in module adblockplus

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M modules/adblockplus/manifests/init.pp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M modules/adblockplus/manifests/log.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/adblockplus/manifests/puppet.pp View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/adblockplus/manifests/sudo.pp View 1 chunk +1 line, -1 line 0 comments Download
M modules/adblockplus/manifests/user.pp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
f.lopez
June 20, 2017, 4:42 p.m. (2017-06-20 16:42:42 UTC) #1
mathias
https://codereview.adblockplus.org/29469584/diff/29469585/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29469584/diff/29469585/modules/adblockplus/manifests/init.pp#newcode106 modules/adblockplus/manifests/init.pp:106: mode => '600', Now that we're at it, can't ...
June 20, 2017, 5:09 p.m. (2017-06-20 17:09:03 UTC) #2
f.lopez
June 21, 2017, 10:15 a.m. (2017-06-21 10:15:34 UTC) #3
mathias
June 21, 2017, 2:11 p.m. (2017-06-21 14:11:33 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld