Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469600: #1634 - Update file resource syntax in module filtermaster (Closed)

Created:
June 20, 2017, 4:52 p.m. by f.lopez
Modified:
June 22, 2017, 9:49 a.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1634 - Update file resource syntax in module filtermaster

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment number 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M modules/filtermaster/manifests/init.pp View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
f.lopez
June 20, 2017, 4:52 p.m. (2017-06-20 16:52:36 UTC) #1
mathias
https://codereview.adblockplus.org/29469600/diff/29469601/modules/filtermaster/manifests/init.pp File modules/filtermaster/manifests/init.pp (right): https://codereview.adblockplus.org/29469600/diff/29469601/modules/filtermaster/manifests/init.pp#newcode79 modules/filtermaster/manifests/init.pp:79: mode => '600', Now that we're at it, can't ...
June 20, 2017, 5:03 p.m. (2017-06-20 17:03:32 UTC) #2
f.lopez
June 21, 2017, 10:04 a.m. (2017-06-21 10:04:02 UTC) #3
mathias
June 21, 2017, 2:13 p.m. (2017-06-21 14:13:38 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld