Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469611: #1634 - Update file resource syntax in module hgweb (Closed)

Created:
June 20, 2017, 4:56 p.m. by f.lopez
Modified:
June 22, 2017, 9:47 a.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

#1634 - Update file resource syntax in module hgweb

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment number 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M modules/hgweb/manifests/init.pp View 1 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4
f.lopez
June 20, 2017, 4:56 p.m. (2017-06-20 16:56:36 UTC) #1
mathias
https://codereview.adblockplus.org/29469611/diff/29469612/modules/hgweb/manifests/init.pp File modules/hgweb/manifests/init.pp (right): https://codereview.adblockplus.org/29469611/diff/29469612/modules/hgweb/manifests/init.pp#newcode144 modules/hgweb/manifests/init.pp:144: mode => '644', Now that we're at it, can't ...
June 20, 2017, 5:01 p.m. (2017-06-20 17:01:44 UTC) #2
f.lopez
June 21, 2017, 9:57 a.m. (2017-06-21 09:57:32 UTC) #3
mathias
June 21, 2017, 2:12 p.m. (2017-06-21 14:12:36 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld