Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29469645: #1634 - Update file resource syntax in module web (Closed)

Created:
June 20, 2017, 5:16 p.m. by f.lopez
Modified:
June 22, 2017, 1:36 p.m.
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

#1634 - Update file resource syntax in module web

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment number 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M modules/web/manifests/server.pp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
f.lopez
June 20, 2017, 5:16 p.m. (2017-06-20 17:16:39 UTC) #1
mathias
LGTM. https://codereview.adblockplus.org/29469645/diff/29469646/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29469645/diff/29469646/modules/web/manifests/server.pp#newcode149 modules/web/manifests/server.pp:149: mode => '755', Now that we're at it, ...
June 20, 2017, 5:58 p.m. (2017-06-20 17:58:56 UTC) #2
f.lopez
June 21, 2017, 10:22 a.m. (2017-06-21 10:22:20 UTC) #3
mathias
June 21, 2017, 2:20 p.m. (2017-06-21 14:20:40 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld