hiera/roles/downloadserver.yaml - Issue 29481662: #1980 - Introduce puppet class adblockplus_web in downloadserver module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: hiera/roles/downloadserver.yaml

Issue 29481662: #1980 - Introduce puppet class adblockplus_web in downloadserver module (Closed)

Left Patch Set: For comment 2 Created July 6, 2017, 2:34 p.m.

Right Patch Set: Leave mode out Created July 6, 2017, 5:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 classes:	1 classes:

2 downloadserver:	2 downloadserver:

3 domain: downloads.adblockplus.org	3 domain: downloads.adblockplus.org

4 certificate: downloads.adblockplus.org_sslcert.pem	4 certificate: downloads.adblockplus.org_sslcert.pem

5 private_key: downloads.adblockplus.org_sslcert.key	5 private_key: downloads.adblockplus.org_sslcert.key

6 is_default: true	6 is_default: true

7 adblockplus::web:
mathias 2017/07/06 14:54:42 This should be an include within class downloadser This should be an include within class downloadserver, and the options should be configured in global context here (adblockplus::web::directory).
8 directory:

9 owner: hg

10 mode: 0644

11	7

	8 adblockplus::web::directory:

	9 owner: hg

	10

LEFT	RIGHT