Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29481662: #1980 - Introduce puppet class adblockplus_web in downloadserver module (Closed)

Created:
July 6, 2017, 1:59 p.m. by f.lopez
Modified:
July 6, 2017, 5:37 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1980 - Introduce puppet class adblockplus_web in downloadserver module

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Total comments: 1

Patch Set 3 : For comment 2 still #

Patch Set 4 : Leave mode out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M hiera/roles/downloadserver.yaml View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M modules/downloadserver/manifests/init.pp View 1 2 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10
f.lopez
July 6, 2017, 1:59 p.m. (2017-07-06 13:59:39 UTC) #1
mathias
https://codereview.adblockplus.org/29481662/diff/29481663/modules/downloadserver/manifests/init.pp File modules/downloadserver/manifests/init.pp (right): https://codereview.adblockplus.org/29481662/diff/29481663/modules/downloadserver/manifests/init.pp#newcode40 modules/downloadserver/manifests/init.pp:40: class {'adblockplus::web': Now I get your question from earlier ...
July 6, 2017, 2:14 p.m. (2017-07-06 14:14:36 UTC) #2
f.lopez
On 2017/07/06 14:14:36, mathias wrote: > https://codereview.adblockplus.org/29481662/diff/29481663/modules/downloadserver/manifests/init.pp > File modules/downloadserver/manifests/init.pp (right): > > https://codereview.adblockplus.org/29481662/diff/29481663/modules/downloadserver/manifests/init.pp#newcode40 > ...
July 6, 2017, 2:21 p.m. (2017-07-06 14:21:26 UTC) #3
f.lopez
July 6, 2017, 2:34 p.m. (2017-07-06 14:34:52 UTC) #4
mathias
LGTM. https://codereview.adblockplus.org/29481662/diff/29481671/hiera/roles/downloadserver.yaml File hiera/roles/downloadserver.yaml (right): https://codereview.adblockplus.org/29481662/diff/29481671/hiera/roles/downloadserver.yaml#newcode7 hiera/roles/downloadserver.yaml:7: adblockplus::web: This should be an include within class ...
July 6, 2017, 2:54 p.m. (2017-07-06 14:54:43 UTC) #5
mathias
NOT LGTM. My bad.
July 6, 2017, 2:54 p.m. (2017-07-06 14:54:57 UTC) #6
f.lopez
July 6, 2017, 4:20 p.m. (2017-07-06 16:20:53 UTC) #7
mathias
LGTM.
July 6, 2017, 4:25 p.m. (2017-07-06 16:25:14 UTC) #8
f.lopez
July 6, 2017, 5:09 p.m. (2017-07-06 17:09:00 UTC) #9
mathias
July 6, 2017, 5:13 p.m. (2017-07-06 17:13:26 UTC) #10
LGTM.

Powered by Google App Engine
This is Rietveld