Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29481668: #1980 - Introduce puppet class adblockplus_web in updateserver module (Closed)

Created:
July 6, 2017, 2:20 p.m. by f.lopez
Modified:
July 6, 2017, 4:13 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1980 - Introduce puppet class adblockplus_web in updateserver module

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M modules/updateserver/manifests/init.pp View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4
f.lopez
July 6, 2017, 2:20 p.m. (2017-07-06 14:20:36 UTC) #1
mathias
https://codereview.adblockplus.org/29481668/diff/29481669/modules/updateserver/manifests/init.pp File modules/updateserver/manifests/init.pp (right): https://codereview.adblockplus.org/29481668/diff/29481669/modules/updateserver/manifests/init.pp#newcode17 modules/updateserver/manifests/init.pp:17: class {'adblockplus::web': This should be a simple include.
July 6, 2017, 2:26 p.m. (2017-07-06 14:26:31 UTC) #2
f.lopez
July 6, 2017, 2:45 p.m. (2017-07-06 14:45:36 UTC) #3
mathias
July 6, 2017, 2:52 p.m. (2017-07-06 14:52:42 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld