#1975 - Introduce class adblockplus::web::redirector

See http://hub.eyeo.com/issues/1653 and http://hub.eyeo.com/issues/1975

[Fred, 2017-07-06 17:17:27]

https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
File modules/adblockplus/templates/web/redirector.conf.erb (right):

https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
modules/adblockplus/templates/web/redirector.conf.erb:7: rewrite ^/<%= key
%>(/.*)?$ "<%= target %>" break;
Didn't we want to append the original query string to the redirect target URL?

[mathias, 2017-07-06 17:23:55]

https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
File modules/adblockplus/templates/web/redirector.conf.erb (right):

https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
modules/adblockplus/templates/web/redirector.conf.erb:7: rewrite ^/<%= key
%>(/.*)?$ "<%= target %>" break;
On 2017/07/06 17:17:27, Fred wrote:
> Didn't we want to append the original query string to the redirect target URL?

We do. That is the default behavior of the Nginx rewrite directive in this case:

$ wget --server-response --spider eyeo.to/jobs/test?foo=bar 2>&1 | grep ^--
--2017-07-06 17:22:12--  http://eyeo.to/jobs/test?foo=bar
--2017-07-06 17:22:12--  https://eyeo.com/en/jobs?foo=bar
--2017-07-06 17:22:12--  https://eyeo.com/en/jobs/?foo=bar

[Fred, 2017-07-06 17:30:29]

On 2017/07/06 17:23:55, mathias wrote:
>
https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
> File modules/adblockplus/templates/web/redirector.conf.erb (right):
> 
>
https://codereview.adblockplus.org/29481679/diff/29481680/modules/adblockplus...
> modules/adblockplus/templates/web/redirector.conf.erb:7: rewrite ^/<%= key
> %>(/.*)?$ "<%= target %>" break;
> On 2017/07/06 17:17:27, Fred wrote:
> > Didn't we want to append the original query string to the redirect target
URL?
> 
> We do. That is the default behavior of the Nginx rewrite directive in this
case:
> 
> $ wget --server-response --spider eyeo.to/jobs/test?foo=bar 2>&1 | grep ^--
> --2017-07-06 17:22:12--  http://eyeo.to/jobs/test?foo=bar
> --2017-07-06 17:22:12--  https://eyeo.com/en/jobs?foo=bar
> --2017-07-06 17:22:12--  https://eyeo.com/en/jobs/?foo=bar

Oh, ok. I wasn't aware that that is the default behavior.
LGTM

[f.lopez, 2017-07-06 17:34:06]

The yaml files will be uploaded as different commits right? 

otherwise LGTM