Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29483572: #2007 - Fix $adblockplus::log::rotations computation (Closed)

Created:
July 8, 2017, 6:49 p.m. by f.lopez
Modified:
July 10, 2017, 5:19 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#2007 - Fix $adblockplus::log::rotations computation

Patch Set 1 #

Patch Set 2 : For comments 2 to 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M modules/adblockplus/manifests/log.pp View 1 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
f.lopez
July 8, 2017, 6:49 p.m. (2017-07-08 18:49:19 UTC) #1
mathias
Where is the point if it uses hiera() but neither hiera_array() nor hiera_hash()?
July 9, 2017, 7:05 a.m. (2017-07-09 07:05:02 UTC) #2
f.lopez
On 2017/07/09 07:05:02, mathias wrote: > Where is the point if it uses hiera() but ...
July 10, 2017, 3:19 p.m. (2017-07-10 15:19:29 UTC) #3
mathias
Makes sense.
July 10, 2017, 3:34 p.m. (2017-07-10 15:34:22 UTC) #4
f.lopez
July 10, 2017, 3:57 p.m. (2017-07-10 15:57:07 UTC) #5
mathias
July 10, 2017, 4:19 p.m. (2017-07-10 16:19:20 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld