Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: manifests/nodes.pp
Issue
29483575
:
#2007 - Create abp::legacy::webserver class for hiera compatibility (Closed)
Patch Set: Creates a full commit for refactoring webserver manifest
Created July 10, 2017, 6:29 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: For comment 2
Patch Set 3: Creates a full commit for refactoring webserver manifest
Patch Set 4: For comment 5
Patch Set 5: For comment 9 and 10
Right:
Patch Set 1: None
Patch Set 2: For comment 2
Patch Set 3: Creates a full commit for refactoring webserver manifest
Patch Set 4: For comment 5
Patch Set 5: For comment 9 and 10
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
hiera/roles/web/adblockplus.yaml
manifests/nodes.pp
manifests/webserver.pp
modules/adblockplus/manifests/legacy/webserver.pp
modules/adblockplus/manifests/log.pp
modules/private-stub/hiera/hosts.yaml
View unified diff
|
Download patch
« hiera/roles/web/adblockplus.yaml
('K') |
« hiera/roles/web/adblockplus.yaml
('k') |
manifests/webserver.pp »
('j') |
modules/adblockplus/manifests/log.pp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 import 'issuesserver.pp'
1 import 'issuesserver.pp'
2
import 'webserver.pp'
3
2
4 node default {
3 node default {
5 }
4 }
OLD
NEW
« hiera/roles/web/adblockplus.yaml
('K') |
« hiera/roles/web/adblockplus.yaml
('k') |
manifests/webserver.pp »
('j') |
modules/adblockplus/manifests/log.pp »
('J')
Edit Message
Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility (Closed)
Created July 8, 2017, 8:09 p.m. by f.lopez
Modified July 12, 2017, 10:33 p.m.
Reviewers: mathias
Base URL:
Comments: 10
This is Rietveld