#2007 - Create abp::legacy::webserver class for hiera compatibility

#2007 - Create abp::legacy::webserver class for hiera compatibility

[mathias, 2017-07-09 07:12:35]

This should be part of the same patch-set that finally removes the original
manifest.

https://codereview.adblockplus.org/29483575/diff/29483576/modules/adblockplus...
File modules/adblockplus/manifests/legacy/webserver.pp (right):

https://codereview.adblockplus.org/29483575/diff/29483576/modules/adblockplus...
modules/adblockplus/manifests/legacy/webserver.pp:24: require =>
Package['mercurial'],
One should not reference resources without them being defined or otherwise
ensured to be available in the same context.

https://codereview.adblockplus.org/29483575/diff/29483576/modules/adblockplus...
modules/adblockplus/manifests/legacy/webserver.pp:49: require => [
One should not reference resources without them being defined or otherwise
ensured to be available in the same context.

[mathias, 2017-07-12 16:13:46]

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
File hiera/roles/web/adblockplus.yaml (right):

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:6: adblockplus::packages:
Both make and doxygen are actual requirements for something configured in the
manifest, hence they should be ensured in that context.

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:19: options:
Aren't options obsolete now?

https://codereview.adblockplus.org/29483575/diff/29485600/modules/adblockplus...
File modules/adblockplus/manifests/log.pp (right):

https://codereview.adblockplus.org/29483575/diff/29485600/modules/adblockplus...
modules/adblockplus/manifests/log.pp:94: $rotations =
hiera_hash('adblockplus::log::rotations', {})
Looks like an unrelated change to me, something that should end up in a distinct
patch-set (didn't I just review one like this a few days ago?)

[f.lopez, 2017-07-12 16:25:59]

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
File hiera/roles/web/adblockplus.yaml (right):

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:6: adblockplus::packages:
On 2017/07/12 16:13:46, mathias wrote:
> Both make and doxygen are actual requirements for something configured in the
> manifest, hence they should be ensured in that context.

Acknowledged.

https://codereview.adblockplus.org/29483575/diff/29485600/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:19: options:
On 2017/07/12 16:13:46, mathias wrote:
> Aren't options obsolete now?

Acknowledged.

https://codereview.adblockplus.org/29483575/diff/29485600/modules/adblockplus...
File modules/adblockplus/manifests/log.pp (right):

https://codereview.adblockplus.org/29483575/diff/29485600/modules/adblockplus...
modules/adblockplus/manifests/log.pp:94: $rotations =
hiera_hash('adblockplus::log::rotations', {})
On 2017/07/12 16:13:46, mathias wrote:
> Looks like an unrelated change to me, something that should end up in a
distinct
> patch-set (didn't I just review one like this a few days ago?)

Agggh your are right, my mistake

[mathias, 2017-07-12 18:01:09]

https://codereview.adblockplus.org/29483575/diff/29487671/hiera/roles/web/adb...
File hiera/roles/web/adblockplus.yaml (right):

https://codereview.adblockplus.org/29483575/diff/29487671/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:22:
repository=/opt/sitescripts/sitescripts/subscriptionlist
So this is a repository maintained by the resources defined in the legacy
webserver manifest? I am not sure I like this one being inside the sitescripts
working copy (to not call it the sitescripts installation).

[f.lopez, 2017-07-12 19:05:44]

https://codereview.adblockplus.org/29483575/diff/29487671/hiera/roles/web/adb...
File hiera/roles/web/adblockplus.yaml (right):

https://codereview.adblockplus.org/29483575/diff/29487671/hiera/roles/web/adb...
hiera/roles/web/adblockplus.yaml:22:
repository=/opt/sitescripts/sitescripts/subscriptionlist
On 2017/07/12 18:01:09, mathias wrote:
> So this is a repository maintained by the resources defined in the legacy
> webserver manifest? I am not sure I like this one being inside the sitescripts
> working copy (to not call it the sitescripts installation).

Actually I misread the code at the beginning, it should be
/home/www/subscritionlist cause it's pointing to the subscriptionlist repository
and in this code it is pointing somewhere else. Gonna push another version of
this

[mathias, 2017-07-12 21:23:34]

LGTM.