#2007 - Create abp::legacy::webserver class for hiera compatibility

modules/adblockplus/manifests/log.pp

 # == Class: adblockplus::log
 #
 # Default root namespace for integrating custom logging entities.
 #
 # === Parameters:
 #
 # [*ensure*]
 #   Whether associated resources are ment to be 'present' or 'absent'.
 #
 # [*name*]
 #   Used as label to connect adblockplus::log::tracker instances to class
 #   adblockplus::log::forwarder, defaults to 'adblockplus::log'.
 #
 # [*rotations*]
 #   A hash of adblockplus::log::rotation $name => $parameter items
-#   to set up in this context, i.e. via Hiera.
+#   to set up in this context via Hiera only.
 #
 # [*trackers*]
 #   A hash of adblockplus::log::rotation $title => $parameter items
 #   to set up in this context, i.e. via Hiera.
 #
 # === Examples:
 #
 #   class {'adblockplus::log':
 #     rotations => {
 #       # see adblockplus::log::rotation
 #     },
 #     trackers => {
 #       # see adblockplus::log::tracker
 #     },
 #   }
 #
 class adblockplus::log (
   $ensure = 'present',
-  $rotations = hiera('adblockplus::log::rotations', {}),
   $trackers = hiera('adblockplus::log::trackers', {}),
 ) {
 
   include adblockplus
   include stdlib
 
   # Used as internal constants within adblockplus::log::* resources
   $directory = "$adblockplus::directory/log/data"
   $user = 'log'
 
@@ skipping 39 matching lines @@
     groups => [$group],
     home => "$adblockplus::directory/log",
     managehome => true,
     require => [
       File[$adblockplus::directory],
       User['fluent'],
     ],
   }
 
   # See modules/adblockplus/manifests/log/rotation.pp
+  $rotations = hiera_hash('adblockplus::log::rotations', {})

[mathias, 2017/07/12 16:13:46]

Looks like an unrelated change to me, something that should end up in a distinct
patch-set (didn't I just review one like this a few days ago?)

[f.lopez, 2017/07/12 16:25:59]

Agggh your are right, my mistake

   create_resources('adblockplus::log::rotation', $rotations)
 
   # See modules/adblockplus/manifests/log/tracker.pp
   create_resources('adblockplus::log::tracker', $trackers)
 }