hiera/roles/web/adblockplus.yaml - Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: hiera/roles/web/adblockplus.yaml

Issue 29483575: #2007 - Create abp::legacy::webserver class for hiera compatibility (Closed)

Left Patch Set: For comment 5 Created July 12, 2017, 5:17 p.m.

Right Patch Set: For comment 9 and 10 Created July 12, 2017, 7:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 classes:	1 classes:

2 nodejs:	2 nodejs:

3 adblockplus::legacy::webserver:	3 adblockplus::legacy::webserver:

4 adblockplus::log:	4 adblockplus::log:

5	5

6 adblockplus::log::rotations:	6 adblockplus::log::rotations:

7 nginx_email_submission:	7 nginx_email_submission:

8 count: 120	8 count: 120

9 ensure: present	9 ensure: present

10 interval: monthly	10 interval: monthly

11 path: /var/log/nginx/email_submission	11 path: /var/log/nginx/email_submission

12	12

13 nodejs::packages:	13 nodejs::packages:

14 jsdoc:	14 jsdoc:

15	15

16 sitescripts::configfragments:	16 sitescripts::configfragments:

17 formmail_template:	17 formmail_template:

18 content: \|	18 content: \|

19 [multiplexer]	19 [multiplexer]

20 sitescripts.subscriptions.web.fallback =	20 sitescripts.subscriptions.web.fallback =

21 [subscriptions]	21 [subscriptions]

22 repository=/opt/sitescripts/sitescripts/subscriptionlist	22 repository=/home/www/subscriptionlist
mathias 2017/07/12 18:01:09 So this is a repository maintained by the resource So this is a repository maintained by the resources defined in the legacy webserver manifest? I am not sure I like this one being inside the sitescripts working copy (to not call it the sitescripts installation). f.lopez 2017/07/12 19:05:44 Actually I misread the code at the beginning, it s Show quoted text On 2017/07/12 18:01:09, mathias wrote: > So this is a repository maintained by the resources defined in the legacy > webserver manifest? I am not sure I like this one being inside the sitescripts > working copy (to not call it the sitescripts installation). Actually I misread the code at the beginning, it should be /home/www/subscritionlist cause it's pointing to the subscriptionlist repository and in this code it is pointing somewhere else. Gonna push another version of this
23	23

LEFT	RIGHT