#2007 - Use ensure_resources() to define $nginx::modules

#2007 - Use ensure_resources() to define $nginx::modules

For modules that doesn't require to set any variable, the name of the module alone should suffice, create_resources doesn't support a suitable default to create a hash, however, ensure_resources allows for a suitable default that merges into the string creating a hash, if the same variable is set via hiera, the hiera variable has preference

[mathias, 2017-07-14 06:18:33]

So all of that cryptic explanation and implementation-details-based hacking only
to avoid "key: {}" in Hiera?

[f.lopez, 2017-07-14 15:14:56]

On 2017/07/14 06:18:33, mathias wrote:
> So all of that cryptic explanation and implementation-details-based hacking
only
> to avoid "key: {}" in Hiera?

well, when you put it like that... but yes.

[mathias, 2017-07-14 15:45:35]

On 2017/07/14 15:14:56, f.lopez wrote:
> well, when you put it like that... but yes.

Well I guess this needs a different commit message then. It's not a fix.

[f.lopez, 2017-07-14 15:54:01]

On 2017/07/14 15:45:35, mathias wrote:
> On 2017/07/14 15:14:56, f.lopez wrote:
> > well, when you put it like that... but yes.
> 
> Well I guess this needs a different commit message then. It's not a fix.

That is fair, what about: "Avoid explicit empty hash for $nginx::modules"

[mathias, 2017-07-14 16:34:23]

On 2017/07/14 15:54:01, f.lopez wrote:
> That is fair, what about: "Avoid explicit empty hash for $nginx::modules"

A commit message should be a summarization of the patch-set, not a cryptic
fragment of the rationale or motivation. Example:
"Use ensure_resources() to define $nginx::modules".

[f.lopez, 2017-07-14 16:40:50]

On 2017/07/14 16:34:23, mathias wrote:
> On 2017/07/14 15:54:01, f.lopez wrote:
> > That is fair, what about: "Avoid explicit empty hash for $nginx::modules"
> 
> A commit message should be a summarization of the patch-set, not a cryptic
> fragment of the rationale or motivation. Example:
> "Use ensure_resources() to define $nginx::modules".

You are right thanks, I changed the commit message in the title.

[mathias, 2017-07-14 16:45:05]

LGTM.