Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29491555: Noissue - Check if ExtensionPanel has onSearch before adding listener (Closed)

Created:
July 18, 2017, 5:28 a.m. by Manish Jethani
Modified:
July 20, 2017, 10:42 a.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Firefox's ExtensionPanel object does not have an onSearch event: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/devtools.panels/ExtensionPanel This is causing the code to throw an error. We should check if the property exists before trying to access it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M devtools.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
July 18, 2017, 5:29 a.m. (2017-07-18 05:29:05 UTC) #1
Manish Jethani
Patch Set 1 Firefox's ExtensionPanel object does not have an onSearch event: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/devtools.panels/ExtensionPanel This is ...
July 18, 2017, 5:32 a.m. (2017-07-18 05:32:43 UTC) #2
Sebastian Noack
LGTM
July 18, 2017, 4:37 p.m. (2017-07-18 16:37:41 UTC) #3
Wladimir Palant
July 20, 2017, 10:42 a.m. (2017-07-20 10:42:59 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld