Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29493618: #2007 - Move jsdoc package inside legacy module (Closed)

Created:
July 20, 2017, 5:38 p.m. by f.lopez
Modified:
July 20, 2017, 7:03 p.m.
Reviewers:
mathias
CC:
Fred, f.nicolaisen
Visibility:
Public.

Description

#2007 - Move jsdoc package inside legacy module

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M hiera/roles/web/adblockplus.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
M modules/adblockplus/manifests/legacy/webserver.pp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
f.lopez
July 20, 2017, 5:38 p.m. (2017-07-20 17:38:48 UTC) #1
mathias
https://codereview.adblockplus.org/29493618/diff/29493619/modules/adblockplus/manifests/legacy/webserver.pp File modules/adblockplus/manifests/legacy/webserver.pp (right): https://codereview.adblockplus.org/29493618/diff/29493619/modules/adblockplus/manifests/legacy/webserver.pp#newcode27 modules/adblockplus/manifests/legacy/webserver.pp:27: nodejs::package{'jsdoc':} The new line before the closing bracket is ...
July 20, 2017, 6:30 p.m. (2017-07-20 18:30:56 UTC) #2
f.lopez
July 20, 2017, 6:41 p.m. (2017-07-20 18:41:45 UTC) #3
mathias
July 20, 2017, 6:42 p.m. (2017-07-20 18:42:15 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld