Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29497628: #1255 - Move issuetracker configuration from nodes.pp to hiera (Closed)

Created:
July 25, 2017, 4:47 p.m. by f.lopez
Modified:
July 25, 2017, 7:40 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#1255 - Move issuetracker configuration from nodes.pp to hiera

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -104 lines) Patch
A hiera/roles/issueserver.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
R manifests/issuesserver.pp View 1 chunk +0 lines, -99 lines 0 comments Download
R manifests/nodes.pp View 1 chunk +0 lines, -4 lines 0 comments Download
M manifests/site.pp View 1 chunk +0 lines, -1 line 0 comments Download
A modules/adblockplus/manifests/legacy/issueserver.pp View 1 1 chunk +107 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
f.lopez
July 25, 2017, 4:47 p.m. (2017-07-25 16:47:14 UTC) #1
mathias
https://codereview.adblockplus.org/29497628/diff/29497629/modules/adblockplus/manifests/legacy/issueserver.pp File modules/adblockplus/manifests/legacy/issueserver.pp (right): https://codereview.adblockplus.org/29497628/diff/29497629/modules/adblockplus/manifests/legacy/issueserver.pp#newcode9 modules/adblockplus/manifests/legacy/issueserver.pp:9: include private::trac Please add an empty line above this ...
July 25, 2017, 6:06 p.m. (2017-07-25 18:06:53 UTC) #2
f.lopez
July 25, 2017, 6:41 p.m. (2017-07-25 18:41:17 UTC) #3
mathias
July 25, 2017, 6:59 p.m. (2017-07-25 18:59:57 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld