Issue 5459 - Add support to show a notification based on the number of ads blocked

lib/notification.js

Index: lib/notification.js
diff --git a/lib/notification.js b/lib/notification.js
index 311e4e881389424155f1a61a3c351a3f69cfaf88..39dfef4047a63ab4cd93023c6d426cd6d9a51a8f 100644
--- a/lib/notification.js
+++ b/lib/notification.js
@@ -304,6 +304,16 @@ let Notification = exports.Notification =
           continue;
       }
 
+      if (typeof notification.blocked_total_min == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||
+          notification.blocked_total_min > Prefs.blocked_total))
+        continue

[Wladimir Palant, 2017/08/15 10:31:21]

Nit: please run ESLint. There should be a semicolon at the end of this
statement. Also, we usually require brackets around the body even if it is the
condition that is spanning multiple lines - ESLint cannot flag that. Yes, I am
aware that this rule already isn't being followed for the block above already.

[wspee, 2017/08/21 15:18:21]

Of course, sorry forgot to use ESLint.

+
+      if (typeof notification.blocked_total_max == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||
+          notification.blocked_total_max < Prefs.blocked_total))
+        continue

[Wladimir Palant, 2017/08/15 10:31:21]

We should use camelCase for consistency. Also, we should expect structured data,
something like:

  blockedTotal: {min: 0, max: 4000}

I just discussed this with Felix, and the conclusion is that this condition
belongs into the targets array, it shouldn't be there on its own.

[wspee, 2017/08/21 15:18:21]

I implemented the syntax from the issue (#5457), then it's also consistent with
extensionVersion, etc..

+
       if (!notificationToShow ||
           getNumericalSeverity(notification) >
             getNumericalSeverity(notificationToShow))