Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: scss/forms/_basic.scss

Issue 29510560: Issue 4633 - Default form styles (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Addressed NITs Created Aug. 11, 2017, 3:23 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scss/forms/_basic.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/scss/forms/_basic.scss
@@ -0,0 +1,74 @@
+/*!
+ * This file is part of website-defaults
+ * Copyright (C) 2016-2017 eyeo GmbH
+ *
+ * website-defaults is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * website-defaults is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/*******************************************************************************
+ * Basic forms fields
+ *******************************************************************************
+ * 1. Reset
+ ******************************************************************************/
+
+/* 1. Reset
+ ******************************************************************************/
+
+input,
+optgroup,
+select,
+textarea
+{
+ box-sizing: border-box;
+ margin: 0px;
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that this effects Firefox a
ire 2017/09/13 07:59:57 Done.
+ font: inherit;
+}
+
+/**
+ * Show the overflow in IE and Edge
+ */
+
+input
+{
+ overflow: visible;
+}
+
+/**
+ * Remove the inheritance of text transform in Edge, Firefox, and IE.
+ */
+
+select
+{
+ text-transform: none;
+}
+
+fieldset,
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that the rest of these styl
+legend
+{
+ display: block;
+ margin: 0px;
+ padding: 0px;
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that this is correcting Fir
ire 2017/09/13 07:59:57 No longer relevant with update
+ border: 0px;
+}
+
+textarea
+{
+ overflow: auto;
juliandoucette 2017/08/24 12:35:24 NIT: I think we should mention that this is removi
ire 2017/09/13 07:59:57 Done.
+}
+
+[type="checkbox"],
+[type="radio"]
+{
+ padding: 0px;
juliandoucette 2017/08/24 12:35:23 NIT: I think we should mention that we are removin
ire 2017/09/13 07:59:57 Done.
+}

Powered by Google App Engine
This is Rietveld