Issue 29510566: Issue 5199 - Add privacy policy link to adblockbrowser.org (Closed)
|
Created:
Aug. 9, 2017, 9:34 a.m. by ire Modified:
Sept. 13, 2017, 12:34 p.m. Reviewers:
juliandoucette Base URL:
https://hg.adblockplus.org/web.adblockbrowser.org Visibility:
Public. |
DescriptionIssue 5199 - Add privacy policy link to adblockbrowser.org
Patch Set 1 #
Total comments: 7
Patch Set 2 : Change privacy policy link to abb for android #MessagesTotal messages: 12
Ready for review.
+Jeen +Judith Will you please address the issues below in the form of comments (or email if you are unsure how to use comments in rietveld)? https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> - Shouldn't this be 2015 - 2017? - This section of the privacy policy no longer exists
done https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> On 2017/08/09 12:49:58, juliandoucette wrote: > - Shouldn't this be 2015 - 2017? No, 2017 is fine. From a German law perspective the copyright is not necessary at all but as it makes sense from an US perspective, you would always use the year of the latest update (it is different for GPL, where you can coose between a period or the latest version). > - This section of the privacy policy no longer exists Wouldn't be https://adblockplus.org/en/privacy#collection-and-processing - Adblock Browser for iOS - Crash and error reporter the right section?
Thanks Judith! Please find followup questions below. https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> On 2017/08/09 13:04:25, j.nink wrote: > No, 2017 is fine. From a German law perspective the copyright is not necessary > at all but as it makes sense from an US perspective, you would always use the > year of the latest update (it is different for GPL, where you can coose between > a period or the latest version). Noted. (For my information:) Does this copyright notice pertain to the contents of this website or something else? This website does not yet explicitly state the license of it's source code and contents (like our Acceptable Ads website does). Is your answer the same if I specify that the source code of this website is GPL3.0+ and the content is CC-BY-ND 4.0? > Wouldn't be https://adblockplus.org/en/privacy#collection-and-processing - > Adblock Browser for iOS - Crash and error reporter the right section? It seems. But I am not a lawyer. Are the contents of that section what you intended to link to when you (or Jeen) requested this change?
Jeen, could you respond to the linking part? https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> On 2017/08/09 15:41:51, juliandoucette wrote: > On 2017/08/09 13:04:25, j.nink wrote: > > No, 2017 is fine. From a German law perspective the copyright is not necessary > > at all but as it makes sense from an US perspective, you would always use the > > year of the latest update (it is different for GPL, where you can coose > between > > a period or the latest version). > > Noted. > > (For my information:) > > Does this copyright notice pertain to the contents of this website or something > else? > only to the website content (meaning text, imagines, if any). > This website does not yet explicitly state the license of it's source code and > contents (like our Acceptable Ads website does). Is your answer the same if I > specify that the source code of this website is GPL3.0+ and the content is > CC-BY-ND 4.0? I would need to check CC-BY-ND 4.0 as I'm not familiar with this license. But in general I'm (personally) not a big fan of text licensing. I would always stick to the general copyright protection provided by law, as Jeen did here. > > > Wouldn't be https://adblockplus.org/en/privacy#collection-and-processing - > > Adblock Browser for iOS - Crash and error reporter the right section? > > It seems. But I am not a lawyer. Are the contents of that section what you > intended to link to when you (or Jeen) requested this change? must be answered by Jeen. I just guessed.
https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> Judith responded via IRC Judith Nink -> juliandoucette: I didn't request the change. But to me it makes sense, to have the link and you are right, I should make the call, this take my link suggestion. Thanks
BUMP: This is ready to be updated based on my last reply.
On 2017/09/12 13:24:43, juliandoucette wrote: > BUMP: This is ready to be updated based on my last reply. Thanks Julian. I don't understand the previous message by Judith, what is the change being requested?
> Thanks Julian. I don't understand the previous message by Judith, what is the change being requested? See my comment below. Note: I chose android instead of iOS (like Judith suggested) because abb.org is for Android and iOS and Android is above iOS in the privacy policy. https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> Change this URL to https://adblockplus.org/en/privacy#adblock-browser-android
Thanks Julian. Done. https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.tmpl File templates/default.tmpl (right): https://codereview.adblockplus.org/29510566/diff/29510567/templates/default.t... templates/default.tmpl:69: © 2017 <a href="https://eyeo.com/">Eyeo GmbH</a> / Adblock Browser™ and <a href="https://adblockplus.org/">Adblock Plus™</a> are registered trademarks of Eyeo GmbH / <a href="https://adblockplus.org/en/privacy#abb_ios">Privacy Policy</a> On 2017/09/13 12:15:36, juliandoucette wrote: > Change this URL to https://adblockplus.org/en/privacy#adblock-browser-android Done.
LGTM 
|
