Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29512555: Noissue - Adds better locale support to test suite (Closed)

Created:
Aug. 11, 2017, 6:25 a.m. by Jon Sonesen
Modified:
Aug. 11, 2017, 8:38 a.m.
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Noissue - Adds better locale support to test suite

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove pointless sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
A tests/expected_output/de/translate View 1 chunk +1 line, -0 lines 0 comments Download
M tests/expected_output/en/filter View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/expected_output/en/get_page_url@dynamic View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/expected_output/en/get_page_url@static View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/expected_output/en/global View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/expected_output/en/sitemap View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/expected_output/en/translate View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/test_page_outputs.py View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5
Jon Sonesen
Aug. 11, 2017, 6:25 a.m. (2017-08-11 06:25:25 UTC) #1
Jon Sonesen
So bonus: now the tests are ran on both versions of the localized page :)
Aug. 11, 2017, 6:26 a.m. (2017-08-11 06:26:27 UTC) #2
Vasily Kuznetsov
Hi Jon, This L pretty much GTM. Just one small question (see below). Cheers, Vasily ...
Aug. 11, 2017, 7:08 a.m. (2017-08-11 07:08:08 UTC) #3
Jon Sonesen
Thanks for looking! https://codereview.adblockplus.org/29512555/diff/29512556/tests/test_page_outputs.py File tests/test_page_outputs.py (right): https://codereview.adblockplus.org/29512555/diff/29512556/tests/test_page_outputs.py#newcode14 tests/test_page_outputs.py:14: for dirpath, dirnames, filenames in sorted(os.walk(path)): ...
Aug. 11, 2017, 7:43 a.m. (2017-08-11 07:43:56 UTC) #4
Vasily Kuznetsov
Aug. 11, 2017, 8:08 a.m. (2017-08-11 08:08:55 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld