#622 - Use mimeo module on abb website

#622 - Use mimeo module on abb website

[mathias, 2017-08-23 16:54:42]

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
File hiera/roles/web/adblockbrowser.yaml (right):

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:17: proxy_set_header Scheme $scheme;
That's neither necessary nor a valid header.

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:21: proxy_set_header Request-Body
$request_body;
That's neither thought through nor a valid header.

[f.lopez, 2017-08-24 18:16:59]

Incoming review, python code has been modified :(

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
File hiera/roles/web/adblockbrowser.yaml (right):

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:17: proxy_set_header Scheme $scheme;
On 2017/08/23 16:54:42, mathias wrote:
> That's neither necessary nor a valid header.

Done.

https://codereview.adblockplus.org/29525555/diff/29525556/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:21: proxy_set_header Request-Body
$request_body;
On 2017/08/23 16:54:42, mathias wrote:
> That's neither thought through nor a valid header.

Done.

[mathias, 2017-08-24 18:23:38]

https://codereview.adblockplus.org/29525555/diff/29526730/modules/adblockplus...
File modules/adblockplus/files/mimeo.py (right):

https://codereview.adblockplus.org/29525555/diff/29526730/modules/adblockplus...
modules/adblockplus/files/mimeo.py:51: 'body': body,
Wasn't that $request_body in Nginx?

[mathias, 2017-08-24 18:43:43]

https://codereview.adblockplus.org/29525555/diff/29526771/hiera/roles/web/adb...
File hiera/roles/web/adblockbrowser.yaml (right):

https://codereview.adblockplus.org/29525555/diff/29526771/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:26: mimeo_data:
I think this one should be configured in the mimeo module
($adblockplus::web::mimeo::rotation being a hash merged with the defaults). You
can do that as a follow-up or a new patch-set here.

[f.lopez, 2017-08-24 18:46:56]

https://codereview.adblockplus.org/29525555/diff/29526771/hiera/roles/web/adb...
File hiera/roles/web/adblockbrowser.yaml (right):

https://codereview.adblockplus.org/29525555/diff/29526771/hiera/roles/web/adb...
hiera/roles/web/adblockbrowser.yaml:26: mimeo_data:
On 2017/08/24 18:43:43, mathias wrote:
> I think this one should be configured in the mimeo module
> ($adblockplus::web::mimeo::rotation being a hash merged with the defaults).
You
> can do that as a follow-up or a new patch-set here.

I'll do it here, wait for it.

[mathias, 2017-08-24 19:30:10]

https://codereview.adblockplus.org/29525555/diff/29526774/modules/adblockplus...
File modules/adblockplus/manifests/web/mimeo.pp (right):

https://codereview.adblockplus.org/29525555/diff/29526774/modules/adblockplus...
modules/adblockplus/manifests/web/mimeo.pp:88: content => join([
Not that easy, if one specifies $source the $content will cause Puppet to fail
with an error. You need a conditional around that, using undef when $rotation
contains $source.

[mathias, 2017-08-24 20:10:48]

LGTM.