Issue 29529783: Noissue - Removed redundant code from SVG files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29529783: Noissue - Removed redundant code from SVG files (Closed)

Created:
Aug. 28, 2017, 5:55 p.m. by Thomas Greiner

Modified:
Aug. 29, 2017, 12:10 p.m.

Reviewers:
saroyanm

Visibility:
Public.

Description

We have added abp-logo.svg twice (first in https://hg.adblockplus.org/adblockplusui/rev/e8bd155637e7 and then in https://hg.adblockplus.org/adblockplusui/rev/01caefcbe1e1) and we redundantly specify the image dimensions in checkmark.svg. Therefore this review contains the following changes: - Replaced skin/abp-logo.svg with skin/mobile/abp-logo.svg - Removed "width" and "height" attributes in checkmark.svg

Patch Set 1 #

Patch Set 2 : #

Created: Aug. 29, 2017, 9:25 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -30 lines)			Patch
M	skin/abp-logo.svg	View		1 chunk	+28 lines, -1 line	0 comments	Download
R	skin/mobile/abp-logo.svg	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
M	skin/mobile/checkmark.svg	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

The removed Icon is missing from the review. I can see only "skin/abp-logo.svg" Modified, but ...

Aug. 28, 2017, 6:05 p.m. (2017-08-28 18:05:56 UTC) #2

Thomas Greiner

On 2017/08/28 18:05:56, saroyanm wrote: > The removed Icon is missing from the review. > ...

Aug. 29, 2017, 9:30 a.m. (2017-08-29 09:30:05 UTC) #3

saroyanm

Aug. 29, 2017, 9:43 a.m. (2017-08-29 09:43:44 UTC) #4

On 2017/08/29 09:30:05, Thomas Greiner wrote:
> On 2017/08/28 18:05:56, saroyanm wrote:
> > The removed Icon is missing from the review.
> > I can see only "skin/abp-logo.svg" Modified, but not
> "skin/mobile/abp-logo.svg"
> > Removed.
> 
> My bad. Forgot to use `hg remove` for that one but instead simply removed the
> file.
> 
> > Also, can you please let me know which tool are you using for clearing the
SVG
> > content?
> 
> I'm doing it manually but Jeen has been using the export feature of her editor
> for the most recent SVGs she provided.
> 
> Note that I didn't modify abp-logo.svg but merely moved the one from
> skin/mobile/ to skin/ to replace the existing one. The only modification I
made
> in this review concerns checkmark.svg.

Noted: LGTM

Expand All Messages | Collapse All Messages