Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29531703: #3197 - Use of hash for parameters in legacy website (Closed)

Created:
Aug. 30, 2017, 5:01 p.m. by f.lopez
Modified:
Aug. 31, 2017, 6:58 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

#3197 - Use of hash for parameters in legacy website

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M hiera/roles/web/adblockplus.yaml View 1 1 chunk +11 lines, -0 lines 0 comments Download
M modules/adblockplus/manifests/legacy/webserver.pp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M modules/web/manifests/server.pp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
f.lopez
Aug. 30, 2017, 5:01 p.m. (2017-08-30 17:01:51 UTC) #1
mathias
https://codereview.adblockplus.org/29531703/diff/29531704/modules/adblockplus/manifests/legacy/webserver.pp File modules/adblockplus/manifests/legacy/webserver.pp (right): https://codereview.adblockplus.org/29531703/diff/29531704/modules/adblockplus/manifests/legacy/webserver.pp#newcode12 modules/adblockplus/manifests/legacy/webserver.pp:12: ensure_resource('class', 'web::server', merge({ This is now a new mechanism ...
Aug. 30, 2017, 5:41 p.m. (2017-08-30 17:41:37 UTC) #2
f.lopez
Aug. 31, 2017, 12:16 a.m. (2017-08-31 00:16:39 UTC) #3
f.lopez
I found a bug, the $remote parameter in modules/web/manifests/server.pp works as expected with the adblockbrowser.org ...
Aug. 31, 2017, 12:17 a.m. (2017-08-31 00:17:41 UTC) #4
mathias
Aug. 31, 2017, 6:02 a.m. (2017-08-31 06:02:06 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld