Noissue - ABP blocks -ads classes

Noissue - ABP blocks -ads classes

[juliandoucette, 2017-09-05 14:20:43]

On 2017/09/05 14:17:47, juliandoucette wrote:

I'm circumventing the following ABP rules (probably more than I need to):

::content .advert-mpu, ::content .advert_rectangle_aside, ::content
.advertisementBox, ::content .advertisment-module, ::content .afffix-custom-ad,
::content .article-v2-rail__advert, ::content .ban420x200, ::content
.banner_mpu_integrated, ::content .block--bean-artadocean-text-link-2, ::content
.blocked-ads, ::content .bottom_adspace, ::content .breadads, ::content
.category-advertorial, ::content .cnnStoryElementBoxAd, ::content
.customized_ad_module, ::content .divAdright, ::content .element--ad, ::content
.fiveMinCompanionBanner, ::content .fp-adinsert, ::content
.game-right-ad-container, ::content .google300x250TextFooter, ::content
.gpAdFooter, ::content .header-banner-ads, ::content .homeAddTopText, ::content
.html-advertisement, ::content .inline-adblock, ::content .jobs-ad-marker,
::content .lblAdvert, ::content .linkedin-sponsor, ::content .mainLinkAd,
::content .metaRedirectWrapperTopAds, ::content .mod_r_ad1, ::content
.msnChannelAd, ::content .noAdForLead, ::content .ovAdartikel, ::content
.pb-f-ads-dfp-big-box-300x250, ::content .post__body-ad-center, ::content
.qa_ad_left, ::content .related-ads, ::content .rightColumnRectAd, ::content
.rt-ad-inline, ::content .section-adbox1, ::content .side_adv_right, ::content
.single-ad-anchor, ::content .sponsorStrip, ::content .sponsored_links_section,
::content .tbl_ad, ::content .thread-ad-holder, ::content .topAdCenter,
::content .tower_ad, ::content .vert-adsBlock, ::content .wd_ads, ::content
.widget_cxad, ::content .x01-ad, ::content
a[href^="//t.MtagMonetizationA.com/"], ::content
a[href^="http://galleries.pinballpublishernetwork.com/"], ::content
a[href^="http://www.down1oads.com/"], ::content .component-zergnet, ::content
.abp_ob_wl, ::content #ad_banner, ::content #ad_main_top, ::content #adtext,
::content #top_ads, ::content .ad-content, ::content .advert1, ::content
.homead, ::content #AD_banner, ::content #TopAd, ::content #ad_header, ::content
#adnews, ::content #bottomad, ::content #googleadsense, ::content
#leaderboard-advertisement, ::content #topad, ::content .ad90, ::content
.ad_bottom, ::content .admiddle, ::content .advertiser, ::content
.chitikaAdBlock, ::content .google_ads, ::content .player_hover_ad, ::content
.rightadv, ::content #PreRollAd, ::content #adposition3, ::content .ad-970,
::content .ad-wrap, ::content .boxad, ::content .home-ads, ::content .panel-ad,
::content .widget_adrotate_widgets, ::content
a[href^="https://click.plista.com/pets"], ::content #adl_300x250, ::content
#adrotate_widgets-3, ::content #head-ad, ::content .adRight, ::content
.adbutton, ::content .adinfo, ::content .contentAd, ::content .list-ads,
::content .module-ad, ::content
a[onmousedown^="this.href='https://paid.outbrain.com/network/redir?"][target="_blank"],
::content .module-zerg, ::content #adspace, ::content
#contentad-adsense-homepage-1, ::content #footer_ad, ::content #leaderAd,
::content .ad-300-250, ::content .ad_3, ::content .advert2, ::content .box-ads,
::content .content_tagsAdTech, ::content .iframe-ad, ::content .js-native-ad,
::content .middle_AD, ::content .strawberry-ads, ::content .widget_taboola,
::content #ad-unit, ::content #adDiv, ::content #taboola_related, ::content
.ad-4, ::content .plistaList >
.plista_widget_underArticle_item[data-type="pet"], ::content .right-ad,
::content .skyscraperAd, ::content .widget-gpt2-ami-ads, ::content #adHeader,
::content #adsensewide, ::content #ka_adRightSkyscraperWide, ::content
.AdSidebar, ::content .SponsoredResults, ::content .ad-wrapper, ::content
.adElement, ::content .ad_728x90, ::content .adplace, ::content .adsbottombox,
::content .advert-content, ::content .b-advert, ::content .container_ad,
::content .gallery-ad, ::content .mod-adopenx, ::content .AD_area, ::content
.ad-160-600, ::content .ad-row, ::content .adHoldert, ::content .ad_wrap,
::content .advert_top, ::content .block-ad, ::content .blog-ads, ::content
.overlay-ads, ::content .quads-ad4, ::content .td-a-rec-id-custom_ad_1,
::content a[target="_blank"][href^="http://api.taboola.com/"], ::content
.widget-ami-zergnet, ::content #ad_zone1, ::content #banner-ad, ::content
#bottom_ad, ::content #extraAdsBlock, ::content #iqadtile1, ::content
#leaderBoardAd, ::content #right_ads, ::content .ad-inserter, ::content
.bullet-sponsored-links-gray, ::content .googleInsideAd, ::content .inner_ad,
::content .marketing-ad, ::content .sam_ad, ::content .sidebar-ads, ::content
a[href^="http://mgid.com/"], ::content #advertiserReports, ::content #bigad,
::content #search_ads, ::content #sponsorAdDiv, ::content #takeover_ad,
::content .ad_text, ::content .advertising-block, ::content .bottom-ad,
::content #adHolder, ::content #text-ads, ::content #topAdSpace_div, ::content
.adOverlay, ::content .ads_header, ::content .advert_container, ::content
.advertising_banner, ::content .feed-s-update--is-sponsored, ::content
.footerad, ::content .item-container-ad, ::content .region-top-ad-position,
::content .rightAd, ::content .sponsor-text, ::content .taboola-container,
::content
a[data-widget-outbrain-redirect^="http://paid.outbrain.com/network/redir?"],
::content #ad_unit, ::content #advertorial, ::content #sidebar_ad, ::content
.ad-atf, ::content .ad-container-300x250, ::content .ad-icon, ::content
.ad-s-rendered, ::content .contentAds, ::content .section-sponsor, ::content
a[href^="http://ad-emea.doubleclick.net/"] {
    display: none;
}

This may become relevant after my coming patchset for
https://issues.adblockplus.org/ticket/5102 lands.

[juliandoucette, 2017-09-05 14:44:52]

Sorry, my last comment was a little unclear. The above rule, which is applied by
ABP, does not apply unless you apply
[this](https://codereview.adblockplus.org/29536654) patchset. Specifically
`::content #text-ads` only applies if ::content comes before #text-ads like it
does on https://acceptableads.com/en/about/criteria#text-ads with the above
Patchset applied. 

What an edge case... :D

[ire, 2017-09-07 08:48:53]

On 2017/09/05 14:44:52, juliandoucette wrote:
> Sorry, my last comment was a little unclear. The above rule, which is applied
by
> ABP, does not apply unless you apply
> [this](https://codereview.adblockplus.org/29536654) patchset. Specifically
> `::content #text-ads` only applies if ::content comes before #text-ads like it
> does on https://acceptableads.com/en/about/criteria#text-ads with the above
> Patchset applied. 
> 
> What an edge case... :D

Let me see if I got this correct. ABP would hide #text-ads if it comes after
some ::content. Currently, the <hr> preceding #text-ads doesn't qualify as
content, but when this is removed, the heading before it does, so #text-ads will
be hidden. So you're changing the names of the IDs to avoid this conflict.
Correct?

[juliandoucette, 2017-09-07 10:20:46]

On 2017/09/07 08:48:53, ire wrote:
> On 2017/09/05 14:44:52, juliandoucette wrote:
> > Sorry, my last comment was a little unclear. The above rule, which is
applied
> by
> > ABP, does not apply unless you apply
> > [this](https://codereview.adblockplus.org/29536654) patchset. Specifically
> > `::content #text-ads` only applies if ::content comes before #text-ads like
it
> > does on https://acceptableads.com/en/about/criteria#text-ads with the above
> > Patchset applied. 
> > 
> > What an edge case... :D
> 
> Let me see if I got this correct. ABP would hide #text-ads if it comes after
> some ::content. Currently, the <hr> preceding #text-ads doesn't qualify as
> content, but when this is removed, the heading before it does, so #text-ads
will
> be hidden. So you're changing the names of the IDs to avoid this conflict.
> Correct?

Mostly. The ::content comes from the fake <hr> added after the h1 via CSS in my
other Patchset.

[ire, 2017-09-08 10:18:55]

On 2017/09/07 10:20:46, juliandoucette wrote:
> On 2017/09/07 08:48:53, ire wrote:
> > On 2017/09/05 14:44:52, juliandoucette wrote:
> > > Sorry, my last comment was a little unclear. The above rule, which is
> applied
> > by
> > > ABP, does not apply unless you apply
> > > [this](https://codereview.adblockplus.org/29536654) patchset. Specifically
> > > `::content #text-ads` only applies if ::content comes before #text-ads
like
> it
> > > does on https://acceptableads.com/en/about/criteria#text-ads with the
above
> > > Patchset applied. 
> > > 
> > > What an edge case... :D
> > 
> > Let me see if I got this correct. ABP would hide #text-ads if it comes after
> > some ::content. Currently, the <hr> preceding #text-ads doesn't qualify as
> > content, but when this is removed, the heading before it does, so #text-ads
> will
> > be hidden. So you're changing the names of the IDs to avoid this conflict.
> > Correct?
> 
> Mostly. The ::content comes from the fake <hr> added after the h1 via CSS in
my
> other Patchset.

Ah I see, good catch!

LGTM