Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29544590: Fixes #5667 - Add missing icons & clean file names action extension (Closed)

Created:
Sept. 14, 2017, 9:29 a.m. by a.shephard
Modified:
Sept. 25, 2017, 1:03 p.m.
Reviewers:
d108, dean, Felix Dahlke
Visibility:
Public.

Description

Fixes #5667 - Add missing icons & clean file names action extension

Patch Set 1 #

Patch Set 2 : Fixes #5667 - Add missing icons & clean file names action extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail-1.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail@120.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail@152.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail@58.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail@58-1.png View Binary file 0 comments Download
D AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Adblock Plus thumbnail@76.png View Binary file 0 comments Download
M AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/Contents.json View 1 5 chunks +16 lines, -14 lines 0 comments Download
A AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/abp-app-ext-icon-60-iphone@2x.png View Binary file 0 comments Download
A AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/abp-app-ext-icon-60-iphone@3x.png View Binary file 0 comments Download
A AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/abp-app-ext-icon-76-iphone@2x.png View Binary file 0 comments Download
A AdblockPlusSafariActionExtension/ActionExtensionAssets.xcassets/AppIcon.appiconset/abp-app-ext-icon-83,5-ipad@2x.png View Binary file 0 comments Download

Messages

Total messages: 7
a.shephard
Sept. 14, 2017, 9:32 a.m. (2017-09-14 09:32:07 UTC) #1
dean
On 2017/09/14 09:32:07, a.shephard wrote: LGTM
Sept. 14, 2017, 12:02 p.m. (2017-09-14 12:02:23 UTC) #2
Felix Dahlke
LGTM
Sept. 18, 2017, 2:27 p.m. (2017-09-18 14:27:12 UTC) #3
d108
I've revised the issue according to new information that will let us reduce the number ...
Sept. 20, 2017, 1:50 a.m. (2017-09-20 01:50:24 UTC) #4
a.shephard
Updated the codereview so that only the necessary icons are added for the Action Extension ...
Sept. 20, 2017, 10:50 a.m. (2017-09-20 10:50:01 UTC) #5
d108
LGTM
Sept. 20, 2017, 4:01 p.m. (2017-09-20 16:01:40 UTC) #6
dean
Sept. 21, 2017, 10:34 a.m. (2017-09-21 10:34:27 UTC) #7
On 2017/09/20 16:01:40, d108 wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld