Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29545595: Noissue - Fixed regression: Logo image broken in mobile options page (Closed)

Created:
Sept. 15, 2017, 10:17 a.m. by Thomas Greiner
Modified:
Sept. 15, 2017, 12:28 p.m.
Reviewers:
saroyanm
CC:
Sebastian Noack
Visibility:
Public.

Description

This change fixes a regression that was introduced in https://hg.adblockplus.org/adblockplusui/rev/bcdec68923d6.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skin/mobile-options.css View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
Thomas Greiner
Sept. 15, 2017, 10:20 a.m. (2017-09-15 10:20:18 UTC) #1
saroyanm
Sept. 15, 2017, 11 a.m. (2017-09-15 11:00:37 UTC) #2
Sorry I've caused the regression.
LGTM with a Detail.

https://codereview.adblockplus.org/29545595/diff/29545596/skin/mobile-options...
File skin/mobile-options.css (left):

https://codereview.adblockplus.org/29545595/diff/29545596/skin/mobile-options...
skin/mobile-options.css:81: background: url(mobile/abp-logo.svg) 0/20px;
Detail: We can use initial values for background-position and size, while by
default they will use same position (0) and scale to the size of the element
which is 20px/20px:
background: url(abp-logo.svg);

Powered by Google App Engine
This is Rietveld