Remove duplicate declaration of mercurial package

modules/filtermaster/manifests/repo_download.pp

 # == Type: filtermaster::repo_download
 #
 # Manage filter list download source repositories for aggregation.
 #
 # === Parameters:
 #
 # [*target*]
 #   An optional alias for use as the download resource name, allows for
 #   repositories with different names. Note that this option is recognized
 #   only when setup via hiera('filtermaster::repo_downloads')!
@@ skipping 10 matching lines @@
 #   }
 #
 define filtermaster::repo_download (
   $target = $title,
   $static_files = [],
 ) {
 
   $directory = "/home/rsync/subscription/$title"
   $repository = "https://hg.adblockplus.org/$title"
 
-  ensure_packages(['mercurial'])

[mathias, 2017/09/18 18:50:08]

When removing that line without either including class adblockplus::mercurial or
explicitly documenting the dependency (irregardless whether its satisfied
implicitly by our base setup) one could argue that you want to introduce a
regression.

-
   exec {"filtermaster::repo_download#$title":
     command => shellquote('hg', 'clone', $repository, $directory),
     onlyif => shellquote('test', '!', '-d', $directory),
     path => ['/usr/local/bin', '/usr/bin', '/bin'],
     require => Package['mercurial'],
     timeout => 0,
     user => 'rsync',
   }
 
   file {"$directory/.hg/hgrc":
     content => template('filtermaster/hgrc.erb'),
     owner => 'rsync',
     require => Exec["filtermaster::repo_download#$title"],
   }
 }