Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29548730: Remove duplicate declaration of mercurial package (Closed)

Created:
Sept. 18, 2017, 6:33 p.m. by f.lopez
Modified:
Sept. 18, 2017, 7:18 p.m.
Reviewers:
mathias
CC:
Fred
Visibility:
Public.

Description

Remove duplicate declaration of mercurial package

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M modules/filtermaster/manifests/repo_download.pp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
f.lopez
Sept. 18, 2017, 6:33 p.m. (2017-09-18 18:33:28 UTC) #1
mathias
https://codereview.adblockplus.org/29548730/diff/29548731/modules/filtermaster/manifests/repo_download.pp File modules/filtermaster/manifests/repo_download.pp (left): https://codereview.adblockplus.org/29548730/diff/29548731/modules/filtermaster/manifests/repo_download.pp#oldcode31 modules/filtermaster/manifests/repo_download.pp:31: ensure_packages(['mercurial']) When removing that line without either including class ...
Sept. 18, 2017, 6:50 p.m. (2017-09-18 18:50:08 UTC) #2
f.lopez
Sept. 18, 2017, 6:57 p.m. (2017-09-18 18:57:00 UTC) #3
mathias
Sept. 18, 2017, 7:09 p.m. (2017-09-18 19:09:10 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld